Hack :imp Signal with Pause UNIMPLEMENTED! signal/end

[sum2012]

@[Unknown] What do you think ?

Code:

GPUCommon.cpp

void GPUCommon::ExecuteOp(u32 op, u32 diff) {
...
case PSP_GE_SIGNAL_HANDLER_PAUSE:
trigger = false;
currentList->signal = behaviour;
ERROR_LOG_REPORT(G3D, "Signal with Pause UNIMPLEMENTED! signal/end: %04x %04x", signal, enddata);
break;
...

Fix Bleach: Soul Carnival Chinese version

   
When press "pause",The game will get struck.
If use my change,the game okay
   

---

Attach v0.9.6-716 original info and gpu debug log

[sum2012]

Add orginal scedisplay,graphic debug log
Modify info and graphic debug log.

[[Unknown]]

It definitely should trigger afaik, but something is wrong with the handling still. Definitely the pause signal is broken atm.

-[Unknown]

[sum2012]

Fix 1 game break 1000 games do not good.
What other games call this ? I want test this change.
(I do not know how to search this error in http://report.ppsspp.org/logs)

[[Unknown]]

Hmm, 3rd Birthday uses them iirc.

http://report.ppsspp.org/logs/kind/84

-[Unknown]

[sum2012]

Thanks.I just find Shaun White Snowboarding have regression
of this change.
   

[cyclonmaster]

(02-02-2014 04:11 PM)sum2012 Wrote:  Thanks.I just find Shaun White Snowboarding have regression
of this change.

Usual approach for this kind of 'fix' is a hack option for further testing until proper fix is found. Am I correct?