Some problems with the new dual-state speed switch

[vsub_]

If "Toggle Speed Limit" is enabled,when you switch to Fixed,the game will run at the set speed.

If you disable "Toggle Speed Limit" and switch to Fixed,the game will run as fast as possible.

If you set a custom speed,it will work with that speed when you switch to Fixed but it you disable=>enable "Toggle Speed Limit",the fixed speed will be reverted back to 60 and you have to press the +\- button tons of times again to set the custom speed.

So a suggestion...keep the custom speed when you are enabling\disabling the "Toggle Speed Limit" option so you don't have to set it again if you want to use custom speed

And btw DonelBueno here said something about settings 0(which I don't really like(what I said above look much better)...we need to add extra button otherwise clicking 60 times will be real pain)but currently the counter don't go below 10 fps

[TheDax]

You're being vague. What platform[s] are you running it on? Swapping between fixed/standard worked fine for me on Windows when I implemented it(though I didn't uncheck the toggle speed limit thing; it probably needs a +/- 5, or maybe a +/- 10 button as well now)..

[vsub_]

Sorry...window xp
Disabling=>Enabling "Toggle Speed Limit" reset the value to 60

[TheDax]

Ah, I misread a portion of your post. Apologies.

Quote:If you disable "Toggle Speed Limit" and switch to Fixed,the game will run as fast as possible.

That's intended behaviour.

Quote:If you set a custom speed,it will work with that speed when you switch to Fixed but it you disable=>enable "Toggle Speed Limit",the fixed speed will be reverted back to 60 and you have to press the +\- button tons of times again to set the custom speed.

It'd be a bit hard to detect if you had a prior speed set while still being able to keep a default, I think, so would an acceptable workaround be an extra set of buttons that do +/- 5, or maybe 10?

[vsub_]

Umm,maybe I didn't understand something.
The value for "Toggle Speed Limit" is used only if that option is enabled.

When it's not enabled,the hotkey will switch between normal speed and unlimited.
When the option is enabled,the hotkey will switch between normal and the custom speed.

What I'm asking is,why the value is autoset to 60 when you enable the limit(Standard don't care what value you set)even if you already set a custom speed and that speed is saved in FrameRate=

There is already ini settings that keep the custom speed(FrameRate)so can't we just keep the custom value when disabling the limit and when we enable it,to set it again.

Like this
Set the value to 120 and when you switch to fixed,the game will run at 120fps.When you disable the limit,the game will run as fast as possible.And you enable the limit again,ppsspp will read FrameRate= and set 120

There is some code in the ppsspp source that is reverting to 60 when you enable the option

Something like that
Press the hotkey
If current state = Standard
FPS = 60
Else
{
If FPS Limit = enabled
Fixed = custom value
Else
Fixed = unlimited
}

And for the button
Click on the option
If limit enabled
Fixed = FrameRate
Else
Fixed = unlimited

[TheDax]

The problem with that, is the UI is designed around integers being set to 0 to hide the options below the checkboxes, and when you check them, a default value gets set.

You'll notice that none of the options keep your previous values if you uncheck them/turn them off. They all go back to a default of some sort, overriding your original value.

[vsub_]

Hmm,that's bad...then some more extra buttons will be better(rather that pressing +/- 1 tons of times if you want 120 for example)

+/- 10 is good enough

[TheDax]

That's the best immediate solution I can think of, since I think reading the old value would require rewriting the entire options UI.

[vsub_]

Is it possible for the gui to support turbo...holding the left button will increase\decrease the value fast.
If it's possible,it will be better that adding extra buttons where you are increasing\decreasing values.

And btw did you know that all hotkeys are currently working in turbo mode...hold for example the key you set to switching speed state and you'll see what I'm talking about(and this is for all hotkeys)

[TheDax]

https://github.com/hrydgard/ppsspp/pull/2761 should help ease the concern about the value being overridden.

As for keys repeating/being in turbo, no, I wasn't aware. That'd probably be more like Henrik's or Unknown's department though.

Also, about buttons increasing in speed over time(like +1, +1 +2 +3 +5, etc), I think that would also require a rewrite...

Henrik would definitely know better than I would.

[vsub_]

Ok thanks...now I have to wait for the buildbot to compile it.

[TheDax]

While we're on the subject of the dual-state switch, it seems it no longer affects Android at all. What could I have possibly broken there? It works perfectly fine on Windows.. :\

[The Phoenix]

(07-12-2013 07:58 AM)daxtsu Wrote:  That's the best immediate solution I can think of, since I think reading the old value would require rewriting the entire options UI.

I thought Henrik, had a entire new UI in the works anyway, and this one we are using is temporary.

[TheDax]

It is in the works, but it's only partially done(you can check out what's new so far with NewUI = True under the [General] section of the INI).

[vsub_]

(07-12-2013 08:30 AM)The Phoenix Wrote:  I thought Henrik, had a entire new UI in the works anyway, and this one we are using is temporary.

The new gui(the settings part)is the same as the old one...at least for now,I don't know if the settings part will be changed too

(07-12-2013 08:13 AM)daxtsu Wrote:  Also, about buttons increasing in speed over time(like +1, +1 +2 +3 +5, etc), I think that would also require a rewrite...

Henrik would definitely know better than I would.

What I meant is like something like this(but in AutoHotkey language...that's the only language I know)

Code:

~LButton::
KeyWait,LButton,t1.5
If ErrorLevel = 1
{
while GetKeyState("LButton")
{
FPS += 1
Sleep,50
ToolTip,% FPS
}
}
ToolTip
Return

If you hold the key for more than 1.5 seconds,a function will be started that constantly increases\decreases the value until you release the key

Edit:Heh,you can control ppsspp values\options with memory searching programs while a game is running