Post Reply 
 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Sound don't work if disabled before starting a game
08-14-2013, 11:11 AM (This post was last modified: 08-14-2013 11:57 AM by TheDax.)
Post: #2
RE: Sound don't work if disabled before starting a game
It's a bug an oversight. The sound mixer isn't being inited at all if sound isn't enabled. It can be fixed in two ways that I can think of, though I'm not sure which is best yet:

1. We can init the sound mixer after enabling sound(and checking to see if Mixer is NULL, and if the emulator is actually running a game via PSP_IsInited to avoid a double init).
2. Init the sound mixer regardless of if sound is enabled or not and simply set the volume to zero so no sounds can be heard, then change the volumes if sound is later re-enabled.

The second option would override existing user settings on audio volume, though. I think I'll go with option 1.


Edit: https://github.com/hrydgard/ppsspp/pull/3165

4GHz AMD 3900X, 32GB DDR4 RAM, 6GB Nvidia RTX 2060, Asus Crosshair 7 Hero (Wifi), Linux
How to ask useful questions: https://web.archive.org/web/20110214010944/http://support.microsoft.com/kb/555375
I'm not Dark_Alex, nor do I claim to be. Our nicknames are merely coincidence.
Find all posts by this user
Quote this message in a reply
Post Reply 


Messages In This Thread
RE: Sound don't work if disabled before starting a game - TheDax - 08-14-2013 11:11 AM

Forum Jump: