But releasing the source code as a tar.gz dump, while good, it not very useful. Can you instead post it as a branch (or two if you modified the "native" project) on github, and maybe make pull requests? If you do, we'll merge your work into the main code base which will save you work updating the port in the future.
But releasing the source code as a tar.gz dump, while good, it not very useful. Can you instead post it as a branch (or two if you modified the "native" project) on github, and maybe make pull requests? If you do, we'll merge your work into the main code base which will save you work updating the port in the future.
Hum, I'll try, but I've never done this before... I am still learning, and git is quite new.
I had modify "native" also. I have done modifications like for the Blackberry port.
Hum, how do I do that (I new to the diff / git / svn things) ? I get a fresh copy of the ppsspp repo, forcing release 0.5, and than I do a diff path/to/my/src/dir path/to/fresh/copy ?
01-11-2013, 12:21 AM (This post was last modified: 01-11-2013, 07:09 AM by Henrik.)
git has a built-in diff tool, use that
If you have simply checked out my repo and made changes, all you need to do to see them is:
git diff
Then you can git add and git commit those changes, and for example push them to a repo of your own on Github. From there you can make a "pull request" which lets me merge or comment very easily.
Also git status is useful to see what you have changed and added.
01-12-2013, 11:45 AM (This post was last modified: 01-12-2013, 12:01 PM by xsacha.)
(01-12-2013, 10:19 AM)ptitSeb Wrote: Here are the diff!
But the files I added in native are not listed.
They are in the native/base folder
I am still not comfortable with git...
I'll merge these with the git for you and mention it's from you.
I've identified a few redundancies (like GLchar defined twice) and some places where the style differs to the project (eg. indenting defines) and fixed those up.
For the Pandomain.cpp, I don't think that's required. From the looks of the code it's just plain SDL with some key tweaks and including eglport. That will merge with PCMain.cpp quite nicely.
For the libraries, I noticed you link asound. I don't see it used at all though (SDL is used for audio). Is this actually needed?
By the way, out of the native funcs, only LaunchBrowser is used by PPSSPP (it's used in the main menu). Is there no way to launch a browser on OpenPandora?
The redundancy, yes, thank you for fixing it ! I wasn't sure at the beginning of the porting on how to do it... So it's a left over my very first try.
About asound, I can force "alsa" for SDL, so I put it, but not sure it's really needed now, but some Pandora user prefers ALSA over OSS...
Ah, LauchBrowser. I didn't think of that. Currently, there is no easy way to launch a Browser on the Pandora. You have to include one in the PND. I have one, so I will look at this in the future.
