fps limiter wont turn off:(

[bigkuhuna123]

It won't turn off and cuts the rest of the options off the screen .7.6-586
Epic 4g touch

[GuilhermeGS2]

Same problem here.

[solarmystic]

A screenshot of the issue would be nice so that the creator of the fps limiter commit that caused the issue can fix it. I don't have an Android device (Windows tester) so I can't exactly see what the problem is.

[Trenico]

You can't take a screenshot because you just cant uncheck it, it is like if it would be activated all time...

[kenny43]

(05-14-2013 05:47 PM)solarmystic Wrote:  A screenshot of the issue would be nice so that the creator of the fps limiter commit that caused the issue can fix it. I don't have an Android device (Windows tester) so I can't exactly see what the problem is.

The issue happens on windows too sweetie, just sayin'

[makotech222]

It works fine on windows. Can you guys give more details? Its not tested for android

[solarmystic]

(05-14-2013 06:36 PM)kenny43 Wrote:  The issue happens on windows too sweetie, just sayin'

I see what you mean. The checkbox for the framelimiter option can't be unticked. I didn't notice it before until I tried to untick it myself on Windows.

@makotech222

I think I understand what they're complaining about now. Here's a screenshot and a youtube video to demonstrate the issue. Basically speaking, no matter how many times you click on the tickbox, you can't untick it.

Screenshot attached.

[GuilhermeGS2]

When I touch to turn off, off and back quickly in less than 1 second.

[makotech222]

Lol i guess its a bad UI design on my part, but there is no reason to untick the box. If you don't want to use the framelimiter, don't press the toggle. The emulator starts at 60 fps. Why would you guys want to untick it in the first place?

[solarmystic]

(05-14-2013 07:29 PM)makotech222 Wrote:  Lol i guess its a bad UI design on my part, but there is no reason to untick the box. If you don't want to use the framelimiter, don't press the toggle. The emulator starts at 60 fps. Why would you guys want to untick it in the first place?

I personally don't see it as an issue myself, especially on Windows, since you can just toggle the actual function on or off using the Left thumbstick.

But for Android users with limited screen estate, it may be more of an issue since the other options may have been obscured by the inability of your added option to be minimized.

[makotech222]

Ah I see. Are android users able to edit the ppsspp.ini file to change framerate? If so, ill just end up removing the option in the graphics screen for android.

[kenny43]

It isn't editable as it is within the apk itself unlike on iOS or windows, though, wouldn't it be better to actually have one of the devs fix the issue so it works fine on other platforms? It has already happened when other users have tried to implement other options as well, like the xBRZ and other filters and it got solved in no time, so it shouldn't be a big deal... At least I think so.

[makotech222]

Hmm... maybe I'll move the option to another page then.

[solarmystic]

(05-14-2013 08:40 PM)makotech222 Wrote:  Hmm... maybe I'll move the option to another page then.

That sounds like a good compromise. Putting it on the third page of the graphics options by itself would be acceptable.

Talking about expected behaviour, this is what the Android folk expected to happen with your Fps Limit checkbox when unticked, using Texture Scaling as an example:-

(notice that the Texture Scaling option can be unticked, and when it is unticked, the options expand and minimize accordingly, saving some crucial space on the already space constrained Android device, most likely running at only 1x or 2x rendering resolution.)

[makotech222]

Yeah i made a pull request just now and fixed it. You can now 'x' out of the fps-limit. Hopefully you will be able to see all of graphic options now. I can't really test it on android though, so just let me know.