[Regression] Harry Potter and the Goblet of Fire - ULES00210

[[Unknown]]

Well, that's quite strange.

There are two main places it uses that information. In Core/Dialog/SavedataParam.cpp, it calls that function once right below:

if (param->msFree.IsValid())

And another time right below:

if (param->sizeInfo.IsValid())

If you leave MemoryStick_FreeSpace() at one of the values that doesn't work, and change:

const u64 freeBytes = MemoryStick_FreeSpace();

To:

const u64 freeBytes = 1ULL * 1024 * 1024 * 1024;

Which one makes it work? I'm thinking it will be the sizeInfo one, but not sure at all. Which ever one it is, both have SavedataParam::GetSpaceText(freeBytes) - what if you take out all the changes, and just change one of the SavedataParam::GetSpaceText(freeBytes) to SavedataParam::GetSpaceText(1ULL * 1024 * 1024 * 1024) - does that fix it?

If yes, that could mean it's reading the string and we're formatting it wrong, which is definitely possible. Otherwise, maybe our structs are wrong or incomplete... or that game is somehow specifying a different version / layout.

-[Unknown]