[Regression] Harry Potter and the Goblet of Fire - ULES00210

[[Unknown]]

Thanks for checking. That does unfortunately match tests, and I think it actually improved things in a couple games because it reports somewhat more believable numbers.

Are you able to compile it? If so, the easiest way to disable the vast majority of that change is to make a simple change to Core/HW/MemoryStick.cpp.

Find:
u64 MemoryStick_FreeSpace()
{

Add after that:
return 1ULL * 1024 * 1024 * 1024; // 1GB

This will make it always report 1GB free as it did before. If this does fix it, that's really strange. Maybe the game just can't believe 8GB are free on the device? Otherwise, if it does not fix it, maybe I made a mistake in SavedataParam::GetSpaceText(), and it's checking the string version...

Also, if you could try putting PPSSPP on a smaller USB stick or SD card, even without any changes (just current master), that would also be interesting. Basically, PPSSPP reports 8GB free until you have less than 8GB free. So, if you put it on a usb stick that has only < 1GB free, it will report whatever is actually free. This allows the game to tell you when you've run out of space (much more common on phones) rather than silently discarding your saves as it did before.

If < 1GB works, but > 1GB doesn't work, that'll also be interesting, and probably means we're doing something wrong reproducing the values of the PSP.

-[Unknown]