[Bug(?)] Phantasy Star Portable 2 and the Port Offset Conundrum

[AdamN]

Okay, i managed to fix the issue with PSP2 when PortOffset is non-zero (and probably other games with similar issue), and yes it was because of Port 0 was offseted in PtpOpen function

Here is the windows build (based on my old adhocstuff refork, since i need to be able to run multiple instance in a single PC for testing)
Win32 build: https://www.dropbox.com/s/iowb4kr00nzbs7...s.zip?dl=0
Win64 build: https://www.dropbox.com/s/dujdrcnec3nryr...4.zip?dl=0

Here is the fix (i forgot how to use github, silly me )
   
You'll need to add that line 1647 in screenshot

Code:

if (sport == 0) sport = -(int)portOffset; //making sure sport is 0 when shifted

(10-22-2016 08:32 AM)Wishdream Wrote:  

(10-20-2016 12:20 PM)AdamN Wrote:  It's not replacing it entirely, binded/listened ports is being shifted by 3000 correctly, while sockets who connection gets established to binded port will get a random port which is normal for client socket.
But i think i can see the issue, its the one with port 3000 i think, or may be not

I guess port 0 shouldn't be shifted and remain 0 so the system will assign any available port randomly (port 0 usually used for client socket anyway, and not being used to bind/listen)

Btw, do you have a working windows build? the one on the latest nightly build at orphis doesn't seem to work with PSP2

PS: the "un-readable bits" in function parameters usually MAC address bytes shown as byte string instead of hex string

Now that you mentioned it, yeah port 0 should remain port 0 to assign a random port.

Well, that's pretty clever to show the MAC address as a byte string. Kind of a way to obscufate the MAC address. Anyways, I got a working copy of the latest nightly build at orphis recently that works with PSP2.

no intention to obscufate the MAC address, i'm just being lazy, that's all it's not even a real MAC address (generated randomly)
Anyway it should be replaced with an easy-to-see MAC address just like shown by AdhocServer