Cant get controlconfig to work

[fgeds]

okay im trying to set custom keyboard binds for each game. Assuming --controlconfig modifies controls.ini. Ppsspp version is 0.9.9.1.718, win64. Nothing is read-only anywhere.

This works:
C:\Games\ppsspp\PPSSPPWindows64.exe --config="c:\temp\temp-settings.ini"


This doesnt:
C:\Games\ppsspp\PPSSPPWindows64.exe --controlconfig="c:\temp\temp-controls.ini"

In fact adding --controlconfig makes the program ignore ppsspp.ini and ignore any changes made, in both settings and controls and reverts to default after program restart. Its like ppsspp doesnt understand what controlconfig means and is getting confused.

[fgeds]

okay im computer illiterate and i dont know how i got there but
http:// github.com/hrydgard/ppsspp/blob/master/Windows/main.cpp

line 419, the bolded word shouldnt that be "controlsConfigFilename"?


char configFilename[MAX_PATH] = { 0 };
char controlsConfigFilename[MAX_PATH] = { 0 };
...
std::strncpy(configFilename, tempStr.c_str(), MAX_PATH);
std::strncpy(configFilename, tempStr.c_str(), MAX_PATH);
...
g_Config.Load(configFilename, controlsConfigFilename);

[Bigpet]

yep, you're right, this is the commit that introduced the copy&paste error: https://github.com/hrydgard/ppsspp/commi...fc33cf4881 so it's been broken since August 31

If you have a github account you can even fix that via the website. If you don't want to make your own pull-request I can do it for you

Btw. you can link to specific lines as well https://github.com/hrydgard/ppsspp/blob/...n.cpp#L419

[fgeds]

im not quite into that online stuff.. i did create an account but im afraid of clicking anywhere in such a big project. that would be great if you could make a request.

[Bigpet]

Alright, but it's not like you could break anything, since you can not change anything directly but merely request that a change should be made. Then a maintainer has to look at those changes and decide whether they're ok or not.

Anyway, here' the pull request I opened: https://github.com/hrydgard/ppsspp/pull/7041

[fgeds]

Wow that was amazingly fast! Awesome. As for me i dont know c++ so checking a c++ project is nonsensical. and w/o a debugger its ten times more difficult anyway. Look we missed another variable there. I did a pull after your example this time. Tbh I feel a bit ashamed for that kind of changes.

[Bigpet]

Well, these things happen, especially in hobby projects where testing rigor is not a thing most of the time. I didn't look at the surrounding code and I didn't test it, because I couldn't bother finding valid *.inis to test.